Alon Bar-Lev has posted comments on this change. Change subject: bll: remove usage of RandomUtils ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/35217/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHandlingCommandBase.java: Line 147: List<VDS> hosts = getVdsDAO().getAllForStoragePoolAndStatus(getStoragePool().getId(), Line 148: VDSStatus.Up); Line 149: if (!hosts.isEmpty()) { Line 150: try { Line 151: return hosts.get(SecureRandom.getInstance("SHA1PRNG").nextInt(hosts.size())); > Yeah, it's not a security issue, Random.nextInt() will suffice, rest is ove so you want to use standard random for both? I try to avoid using that as it is predictable random. please confirm and I will resubmit. Line 152: } catch (NoSuchAlgorithmException e) { Line 153: throw new RuntimeException(e); Line 154: } Line 155: } -- To view, visit http://gerrit.ovirt.org/35217 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id20da6d8eb93ebbd237d20705440c5e583fc486e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
