Sahina Bose has posted comments on this change. Change subject: gluster: DAO for volume snapshot maintenance ......................................................................
Patch Set 7: (2 comments) http://gerrit.ovirt.org/#/c/23372/7/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDao.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeSnapshotDao.java: Line 30: public void removeByClusterId(Guid clusterId); Line 31: Line 32: public void removeByVolumeId(Guid clusterId, Guid volumeId); Line 33: Line 34: public void removeByName(Guid clusterId, String snapshotName); clusterId or volumeId as first parameter? Line 35: Line 36: public void updateSnapshotStatus(Guid snapshotId, GlusterSnapshotStatus status); Line 37: Line 38: public void updateSnapshotStatusByName(Guid clusterId, String snapshotName, GlusterSnapshotStatus status); http://gerrit.ovirt.org/#/c/23372/7/packaging/dbscripts/gluster_volume_snapshot_sp.sql File packaging/dbscripts/gluster_volume_snapshot_sp.sql: Line 43: END; $procedure$ Line 44: LANGUAGE plpgsql; Line 45: Line 46: Create or replace FUNCTION GetGlusterVolumeSnapshotsByVolumeId(v_cluster_id UUID, v_volume_id UUID) Line 47: RETURNS SETOF gluster_volume_snapshots STABLE You could create a view and return that. Line 48: AS $procedure$ Line 49: BEGIN Line 50: RETURN QUERY SELECT * Line 51: FROM gluster_volume_snapshots -- To view, visit http://gerrit.ovirt.org/23372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id60902aad02b852773ad398aaac9bad8ed7793ab Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Nishanth Thomas <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
