Martin Sivák has posted comments on this change. Change subject: engine: Improve reporting when scheduling fails on network ......................................................................
Patch Set 7: (3 comments) http://gerrit.ovirt.org/#/c/29790/7/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/scheduling/policyunits/NetworkPolicyUnit.java: Line 135: } Line 136: Line 137: if (!missingIfs.isEmpty()) { Line 138: String nics = StringUtils.join(missingIfs, ", "); Line 139: log.debug("host {} is missing networks required by VM nics {}", > Notice this has gone back to debug level. Done Line 140: vds.getName(), nics); Line 141: return new ValidationResult(VdcBllMessages.VAR__DETAIL__NETWORK_MISSING, Line 142: String.format("$networkNames %1$s", nics)); Line 143: } Line 186: } Line 187: Line 188: // Check if display network attached to host and has a proper boot protocol Line 189: if (displayNic == null) { Line 190: log.debug("host {} is missing the cluster's display network {}", > Same comment. Done Line 191: host.getName(), Line 192: displayNetwork.getName()); Line 193: return new ValidationResult(VdcBllMessages.VAR__DETAIL__DISPLAY_NETWORK_MISSING, Line 194: String.format("$DisplayNetwork %1$s", displayNetwork.getName())); Line 194: String.format("$DisplayNetwork %1$s", displayNetwork.getName())); Line 195: } Line 196: Line 197: if (displayNic.getBootProtocol() == NetworkBootProtocol.NONE) { Line 198: log.debug("Host {} has the display network {} configured with improper boot protocol on interface {}.", > Same comment. Done Line 199: host.getName(), Line 200: displayNetwork.getName(), Line 201: displayNic.getName()); Line 202: return new ValidationResult(VdcBllMessages.VAR__DETAIL__DISPLAY_NETWORK_HAS_NO_BOOT_PROTOCOL, -- To view, visit http://gerrit.ovirt.org/29790 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic60daf20842ba69457b293f451060e21381faf80 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
