Ayal Baron has posted comments on this change. Change subject: core: SPM election loop if auto-recovery tries to activate non-existing storage domain (#821634) ......................................................................
Patch Set 2: I would prefer that you didn't submit this (2 inline comments) Also, I agree with the commit message which says we shouldn't failover in case of activate and not have specific logic here for autoRecovery. Only problem is how does user initiate spm reselection. I'm not sure what activate of master domain means as you need access to the master domain in order to activate it... Nit: Note that there is no 'elections' going on here, it is a 'selection' process. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainPoolParametersBase.java Line 10: private boolean isAutoRecovery; this should be: changeSpmOnFailure and not isAutoRecovery .................................................... Commit Message Line 12: Actually for my opinion we should not change SPM if we failed on Activate of any domain except case for this comment does not belong here. -- To view, visit http://gerrit.ovirt.org/6923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0ab261ef3d43a644ac7540f4169f391c24a0f9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
