Lior Vernia has posted comments on this change.

Change subject: core: QoS name uniquness
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/34154/5/packaging/dbscripts/upgrade/03_06_0540_qos_name_uniqueness.sql
File packaging/dbscripts/upgrade/03_06_0540_qos_name_uniqueness.sql:

Line 1: -- adding constaint for qos name uniqueness of same context
Line 2: ALTER TABLE qos ADD UNIQUE (qos_type, name, storage_pool_id)
> postfix them with _1 of something.  best effort.
I have to say there's a very small chance that this even happened to anyone... 
They would have had to press OK twice fast on the same dialog... And then to 
not have noticed that two QoS entities were created with the same name, or to 
have decided it had been the desired result.


-- 
To view, visit http://gerrit.ovirt.org/34154
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I16c75592dd8a8745ecffc7728e6523de8be4f857
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to