Allon Mureinik has posted comments on this change. Change subject: core: Image configuration adjustments for cloning a VM ......................................................................
Patch Set 2: Code-Review-1 (4 comments) http://gerrit.ovirt.org/#/c/35225/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2014-11-19 14:57:24 +0200 Line 6: Line 7: core: Image configuration adjustments for cloning a VM Line 8: Line 9: Changeoning a VM, in some cases disk image configurations must be Changeoning? Line 10: applied before executing the command. specifically when cloning a Line 11: VM's snapshot with thin NFS,raw disk allocation , to a VM with thin Line 12: block disk allocation- the raw format needs to be changed to COW. Line 13: Line 6: Line 7: core: Image configuration adjustments for cloning a VM Line 8: Line 9: Changeoning a VM, in some cases disk image configurations must be Line 10: applied before executing the command. specifically when cloning a s/specifically/Specifically Line 11: VM's snapshot with thin NFS,raw disk allocation , to a VM with thin Line 12: block disk allocation- the raw format needs to be changed to COW. Line 13: Line 14: Change-Id: Id924e9beab5d84277fad4f3a2a40b14571beaf22 Line 7: core: Image configuration adjustments for cloning a VM Line 8: Line 9: Changeoning a VM, in some cases disk image configurations must be Line 10: applied before executing the command. specifically when cloning a Line 11: VM's snapshot with thin NFS,raw disk allocation , to a VM with thin s/,/, / s/ , /, / Line 12: block disk allocation- the raw format needs to be changed to COW. Line 13: Line 14: Change-Id: Id924e9beab5d84277fad4f3a2a40b14571beaf22 Line 15: Bug-Url: https://bugzilla.redhat.com/1121397 http://gerrit.ovirt.org/#/c/35225/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java: Line 99: private void adjustDisksImageConfiguration(Collection<DiskImage> diskImages) { Line 100: for (DiskImage diskImage : diskImages) { Line 101: // Adjust disk image configuration if needed. Line 102: if (destStorages.get(diskInfoDestinationMap.get(diskImage.getId()).getStorageIds().get(0)).getStorageStaticData().getStorageType().isBlockDomain() && Line 103: diskImage.getVolumeFormat().equals(VolumeFormat.RAW)) { You can have raw block disks - but only if they're preallocated. Line 104: diskImage.setvolumeFormat(VolumeFormat.COW); Line 105: } Line 106: } Line 107: } -- To view, visit http://gerrit.ovirt.org/35225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id924e9beab5d84277fad4f3a2a40b14571beaf22 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
