Martin Mucha has uploaded a new change for review. Change subject: core: dont fail on empty ranges ......................................................................
core: dont fail on empty ranges Change-Id: I314ff9e62d7515eae334c461a67ce609ca188359 Bug-Url: https://bugzilla.redhat.com/1165025 Signed-off-by: Martin Mucha <[email protected]> --- M backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java M backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/91/35391/1 diff --git a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java index fa72dd6..405b8f9 100644 --- a/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java +++ b/backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelper.java @@ -26,7 +26,7 @@ public ValidationResult validate(ConfigKey key, String value) { if (StringUtils.isBlank(value)) { - return new ValidationResult(false, "The MAC address range cannot be empty."); + return new ValidationResult(true); } try { diff --git a/backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java b/backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java index 63e0e19..c54c6d4 100644 --- a/backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java +++ b/backend/manager/tools/src/test/java/org/ovirt/engine/core/config/entity/helper/MacAddressPoolRangesValueHelperTest.java @@ -43,9 +43,9 @@ { "AA-AA-AA-AA-AA-AA-BB-BB-BB-BB-BB-BB", false }, { "AA:AA:AA:AA:AA:AA-AA:AA:AA:AA:AA:AB,XA:AA:AA:AA:AA:AA-BB:BB:BB:BB:BB:BB", false }, { "01:00:00:00:00:00-01:FF:FF:FF:FF:FF", false}, - { null, false }, - { "", false }, - { " ", false }, + { null, true }, + { "", true }, + { " ", true } }); } } -- To view, visit http://gerrit.ovirt.org/35391 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I314ff9e62d7515eae334c461a67ce609ca188359 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Martin Mucha <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
