Jiří Moskovčák has posted comments on this change. Change subject: webadmin: make it more obvious that thread as cores is enabled ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35316/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostHardwareGeneralModel.java: Line 256: Line 257: Line 258: String fieldValue = String.valueOf(coresPerSocket); Line 259: if (vds.getCountThreadsAsCores()) { Line 260: fieldValue = ConstantsManager.getInstance().getMessages() > I suspect the a NULL value in coresPerSocket or cpuThreds might cause a NPE it won't happen, because there is a check for null(s) on line 254. if (vds.getCpuCores() != null && vds.getCpuSockets() != null && vds.getCpuSockets() != 0) { Line 261: .threadsAsCoresPerSocket(coresPerSocket, vds.getCpuThreads()); Line 262: } Line 263: Line 264: setCoresPerSocket(fieldValue); -- To view, visit http://gerrit.ovirt.org/35316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2fb9d28f3b125a9104fec5f3a887efdbf711b037 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
