Martin Sivák has posted comments on this change. Change subject: core: Push ioTune QoS info when hotplugging disk ......................................................................
Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/33907/9/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 353: ArchStrategyFactory.getStrategy(vm.getClusterArch()).run(new CreateAdditionalControllers(devices)); Line 354: } Line 355: Line 356: static void addIoTuneParams(VM vm, VmDevice vmDevice, Map<String, Long> ioTune) { Line 357: if (FeatureSupported.storageQoS(vm.getVdsGroupCompatibilityVersion())) { > any reason that we won't use this if clause as it was used before? there's This is also used from the hotplug command that does no queries. I suppose I could escape the queries as well if you really insist (I agree that it does the query unnecessarily). Or I can put the condition to the hotplug code as well instead. Line 358: if (ioTune != null) { Line 359: if (vmDevice.getSpecParams() == null) { Line 360: vmDevice.setSpecParams(new HashMap<String, Object>()); Line 361: } -- To view, visit http://gerrit.ovirt.org/33907 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic4bb85cd307089088be77cff28adbc783ebcaedd Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Sivák <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomer Saban <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
