Vojtech Szocs has posted comments on this change.
Change subject: webadmin: detach handlers on hide
......................................................................
Patch Set 1:
Change looks good, but when someone adds new tree-based View and forgets to
override hide() and call treeViewModel.removeHandlers(), we'll have a problem.
I suggest to fix this in a more generic way, for example:
// new AbstractModelBoundTreePopupView.java
public abstract class AbstractModelBoundTreePopupView<T extends Model> extends
AbstractModelBoundPopupView<T> {
public AbstractModelBoundTreePopupView(EventBus eventBus,
CommonApplicationResources resources) {
super(eventBus, resources);
}
@Override
public void hide() {
super.hide();
getTreeViewModel().removeHandlers();
}
protected abstract TreeViewModel getTreeViewModel();
}
// existing AssignTagsPopupView.java
public class AssignTagsPopupView extends
AbstractModelBoundTreePopupView<TagListModel> implements
AssignTagsPopupPresenterWidget.ViewDef {
...
@Override
protected TreeViewModel getTreeViewModel() {
return tree.getTreeViewModel();
}
...
}
Alex, please share your opinions on above.
--
To view, visit http://gerrit.ovirt.org/35349
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56de07f80cbb21fe6362d6df488defe7422cebfb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
