Yair Zaslavsky has uploaded a new change for review. Change subject: core: UnlockImage should be run in new transaction ......................................................................
core: UnlockImage should be run in new transaction As "endAction" is run in suspeneed mode in most cases, and unlock image is a short db operation - it is better to run the unlock image in a new transaction (no compensation is required, as this is endAction). Change-Id: Iddb031f18023db8fab6c1ab7f07cef9942238de2 Signed-off-by: Yair Zaslavsky <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/19/35419/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java index d000196..1eccfe7 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java @@ -32,6 +32,8 @@ import org.ovirt.engine.core.dao.ImageDao; import org.ovirt.engine.core.dao.SnapshotDao; import org.ovirt.engine.core.utils.lock.EngineLock; +import org.ovirt.engine.core.utils.transaction.TransactionMethod; +import org.ovirt.engine.core.utils.transaction.TransactionSupport; /** * Base class for all image handling commands @@ -303,7 +305,13 @@ } protected void unLockImage() { - setImageStatus(ImageStatus.OK); + TransactionSupport.executeInNewTransaction(new TransactionMethod<Void>() { + @Override + public Void runInTransaction() { + setImageStatus(ImageStatus.OK); + return null; + } + }); } protected void setImageStatus(ImageStatus imageStatus) { -- To view, visit http://gerrit.ovirt.org/35419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iddb031f18023db8fab6c1ab7f07cef9942238de2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
