Livnat Peer has posted comments on this change.
Change subject: core: Use StringUtils and getDbFacade (#824497)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkFromVdsInterfaceCommand.java
Line 17: import org.ovirt.engine.core.dal.VdcBllMessages;
Line 18: import org.ovirt.engine.core.utils.NetworkUtils;
Line 19: import org.ovirt.engine.core.utils.linq.LinqUtils;
Line 20: import org.ovirt.engine.core.utils.linq.Predicate;
Line 21:
any reason to add suppress and not serial id?
Line 22: @SuppressWarnings("serial")
Line 23: public class DetachNetworkFromVdsInterfaceCommand<T extends
AttachNetworkToVdsParameters> extends VdsNetworkCommand<T> {
Line 24: public DetachNetworkFromVdsInterfaceCommand(T paramenters) {
Line 25: super(paramenters);
--
To view, visit http://gerrit.ovirt.org/7106
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa0e7119d29809cb7af094a2ea978200c22613f
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Livnat Peer <lp...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
