Oved Ourfali has posted comments on this change.

Change subject: core: Reintroducing foreign keys to async_tasks table
......................................................................


Patch Set 3:

(1 comment)

so what was the original issue that made it work bad in the first place?

http://gerrit.ovirt.org/#/c/35399/3/packaging/dbscripts/upgrade/03_06_0580_reintoduce_async_tasks_fk.sql
File packaging/dbscripts/upgrade/03_06_0580_reintoduce_async_tasks_fk.sql:

Line 1: SELECT fn_db_create_constraint('async_tasks', 
'fk_async_tasks_command_entities_command_id', 'FOREIGN KEY (command_id) 
REFERENCES command_entities(command_id) ON DELETE CASCADE');      
Line 2:                         
whitespaces


-- 
To view, visit http://gerrit.ovirt.org/35399
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2306abce7940f5c8a581ef4f71ddfcb1f6849df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to