Maor Lipchuk has posted comments on this change. Change subject: core: Add lock when importing an exsiting block Storage Domain ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/35509/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddExistingBlockStorageDomainCommand.java: Line 62: } Line 63: Line 64: @Override Line 65: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 66: return Collections.singletonMap(getParameters().getStorageDomainId().toString(), > Please check if getParameters().getStorageDomainId() is not null done Line 67: LockMessagesMatchUtil.makeLockingPair(LockingGroup.STORAGE, VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED)); Line 68: } Line 69: Line 70: protected List<LUNs> getLUNsFromVgInfo(String vgId) { Line 63: Line 64: @Override Line 65: protected Map<String, Pair<String, String>> getExclusiveLocks() { Line 66: return Collections.singletonMap(getParameters().getStorageDomainId().toString(), Line 67: LockMessagesMatchUtil.makeLockingPair(LockingGroup.STORAGE, VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED)); > Please add specific message, this is a generic one "A domain import operati This is already being done every time we lock the Storage. the message should be consstent Line 68: } Line 69: Line 70: protected List<LUNs> getLUNsFromVgInfo(String vgId) { Line 71: List<LUNs> luns = new ArrayList<>(); -- To view, visit http://gerrit.ovirt.org/35509 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43dfed013fcbf9965466a00e01b5c81cc6dc9174 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
