Alon Bar-Lev has posted comments on this change.

Change subject: core : Persist engine session on login and delete on logout
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.ovirt.org/#/c/35361/4/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/SessionDataContainer.java:

Line 247:                 message,
Line 248:                 msgArgs
Line 249:                 );
Line 250:         sessionInfoMap.remove(sessionId);
Line 251:         
getDbFacade().getEngineSessionDao().removeBySessionId(sessionId);
> We can
remove by seq?
Line 252:     }
Line 253: 
Line 254:     private String getPrincipalName(String sessionId) {
Line 255:         return (String) getData(sessionId, PRINCIPAL_PARAMETER_NAME, 
false);


-- 
To view, visit http://gerrit.ovirt.org/35361
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id716d9c6f65898ccd0ffd84d8b05926b78ac9692
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to