Martin Mucha has posted comments on this change. Change subject: engine: Add host poller for setup network actions ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/34970/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworkPoller.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/HostSetupNetworkPoller.java: Line 35: if (System.currentTimeMillis() - timeBeforePoll < POLLING_BREAK) { Line 36: Thread.sleep(POLLING_BREAK); Line 37: } Line 38: } catch (Exception e) { Line 39: // ignore failure. network can go down due to VDSM changing the network here we get probably via failing: org.ovirt.engine.core.vdsbroker.vdsbroker.FutureVDSCommand#get(long, java.util.concurrent.TimeUnit). but if this fails (timeout or whatever), then "polling break" won't be applied, causing busy waiting here: org.ovirt.engine.core.bll.network.host.HostSetupNetworksCommand#invokeSetupNetworksCommand and incorrect waiting period here: org.ovirt.engine.core.bll.network.NetworkConfigurator#awaitVdsmResponse The waiting should have been defined in it's own try/catch prior to returning false PLUS method org.ovirt.engine.core.vdsbroker.vdsbroker.FutureVDSCommand#get(long, java.util.concurrent.TimeUnit). handles exception in wrong way and should be fixed; I'll contact rgolan about it. Line 40: } Line 41: Line 42: return false; Line 43: } -- To view, visit http://gerrit.ovirt.org/34970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic11e71f0ee4e4ed4d6ae9a1d8fe4e5613da7a48f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
