Yaniv Bronhaim has posted comments on this change. Change subject: foreman-integration: Remove domain from hostname to allow rhevh registration ......................................................................
Patch Set 1: Verified-1 (1 comment) something goes wrong with the record update that way - 2014-11-23 18:03:33,506 INFO [org.ovirt.engine.core.services.RegisterServlet] (http--0.0.0.0-8080-6) Registration request: source='10.35.1.10', secured='false', address='192.168.105.74', vdsPort=54321, name= 'david.moo.mee.com', uniqueId='063B20D9-C0C7-43D7-AA72-56D84A1C5408_52:54:00:7c:fe:05' 2014-11-23 18:03:33,518 INFO [org.ovirt.engine.core.bll.RegisterVdsQuery] (http--0.0.0.0-8080-6) Running Command: RegisterVds 2014-11-23 18:03:33,543 WARNING [org.ovirt.engine.core.compat.backendcompat.PropertyInfo] (http--0.0.0.0-8080-6) Unable to get value of property: vdsName for class org.ovirt.engine.core.common.businessentitie s.VdsStatic 2014-11-23 18:03:33,544 WARNING [org.ovirt.engine.core.compat.backendcompat.PropertyInfo] (http--0.0.0.0-8080-6) Unable to get value of property: vdsName for class org.ovirt.engine.core.common.businessentitie s.VdsStatic 2014-11-23 18:03:33,545 INFO [org.ovirt.engine.core.bll.UpdateVdsCommand] (http--0.0.0.0-8080-6) [479a4669] Running command: UpdateVdsCommand internal: true. Entities affected : ID: 38a0a759-5bd8-46a7-af74- 2d771c0d4493 Type: VDSAction group EDIT_HOST_CONFIGURATION with role type ADMIN 2014-11-23 18:03:33,559 WARNING [org.ovirt.engine.core.compat.backendcompat.PropertyInfo] (http--0.0.0.0-8080-6) Unable to get value of property: vdsName for class org.ovirt.engine.core.common.businessentitie s.VdsStatic 2014-11-23 18:03:33,560 WARNING [org.ovirt.engine.core.compat.backendcompat.PropertyInfo] (http--0.0.0.0-8080-6) Unable to get value of property: vdsName for class org.ovirt.engine.core.common.businessentitie s.VdsStatic 2014-11-23 18:03:33,564 WARNING [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (http--0.0.0.0-8080-6) [479a4669] Correlation ID: null, Call Stack: null, Custom Event ID: -1, Message: F ailed to verify Power Management configuration for Host david. 2014-11-23 18:03:33,593 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (http--0.0.0.0-8080-6) [479a4669] Correlation ID: 479a4669, Call Stack: null, Custom Event ID: -1, Message: Host david configuration was updated by <UNKNOWN>. 2014-11-23 18:03:33,594 INFO [org.ovirt.engine.core.bll.RegisterVdsQuery] (http--0.0.0.0-8080-6) [479a4669] RegisterVdsQuery::Register -Updated a registered VDS - Name: david.moo.mee.com, Hostname: 192.168.105.74, UniqueID: 063B20D9-C0C7-43D7-AA72-56D84A1C5408 2014-11-23 18:03:33,622 INFO [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (http--0.0.0.0-8080-6) [479a4669] Correlation ID: null, Call Stack: null, Custom Event ID: -1, Message: Host david.moo.mee.com registered. http://gerrit.ovirt.org/#/c/35450/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java: Line 156: // force to reload vdss by unique ID used later on Line 157: _vdssByUniqueId = null; Line 158: VDS vdsByUniqueId = getVdssByUniqueId().size() != 0 ? getVdssByUniqueId().get(0) : null; Line 159: String registeredVdsName = getParameters().getVdsName().split("\\.")[0]; Line 160: VDS provisionedVds = DbFacade.getInstance().getVdsDao().getByName(registeredVdsName); > why isn't the vdsByUniqueId enough for you? why do you need to fetch it aga 1. as i said before - the registration call comes from node with hostname==ip address and name == name.domain . 2. we don't have uniqueId in this phase. uniqueId is generated for deployed hosts. when provision an host we add the record to db with empty id until the deploy is done. Line 161: if (provisionedVds != null && provisionedVds.getStatus() != VDSStatus.InstallingOS) { Line 162: // if not in InstallingOS status, this host is not provisioned. Line 163: provisionedVds = null; Line 164: } -- To view, visit http://gerrit.ovirt.org/35450 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie95c258def25d2e484d4094784eb0b15d62c7ef3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
