Eli Mesika has uploaded a new change for review.

Change subject: db: fix fn_db_add_config_value_for_versions_up_to
......................................................................

db: fix fn_db_add_config_value_for_versions_up_to

The FOREACH keyword used in the function is not compatible with PG 8.x
and was replaced with a FOR loop that is supported for both 8.x and 9.x

Change-Id: Ice6f9425fae64ebdd4bfcc68d848ec4fdd9acc8a
Signed-off-by: emesika <[email protected]>
---
M packaging/dbscripts/common_sp.sql
1 file changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/00/35600/1

diff --git a/packaging/dbscripts/common_sp.sql 
b/packaging/dbscripts/common_sp.sql
index 178c57b..0d015ab 100644
--- a/packaging/dbscripts/common_sp.sql
+++ b/packaging/dbscripts/common_sp.sql
@@ -607,13 +607,13 @@
 returns void
 AS $procedure$
 declare
-    m   varchar;
+    i   int;
     arr varchar[] := array['3.0', '3.1', '3.2', '3.3', '3.4', '3.5', '3.6'];
 begin
-    FOREACH m IN ARRAY arr
+    FOR i IN array_lower(arr, 1) .. array_upper(arr, 1)
     LOOP
-        perform fn_db_add_config_value(v_option_name, v_val, m);
-        EXIT WHEN  m = v_version;
+        PERFORM fn_db_add_config_value(v_option_name, v_val, arr[i]);
+        EXIT WHEN  arr[i] = v_version;
     END LOOP;
 END; $procedure$
 LANGUAGE plpgsql;


-- 
To view, visit http://gerrit.ovirt.org/35600
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ice6f9425fae64ebdd4bfcc68d848ec4fdd9acc8a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to