Oved Ourfali has posted comments on this change. Change subject: Use empty string instead null for empty foreman parameters ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/35444/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalComputeResource.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ExternalComputeResource.java: Line 8: private String provider; Line 9: private String user; Line 10: Line 11: public String getProvider() { Line 12: return provider != null ? provider : ""; //$NON-NLS-1$ > why? getters and setters should do what they are meant to do, and not manipulate the input/output. Line 13: } Line 14: Line 15: public void setProvider(String provider) { Line 16: this.provider = provider; -- To view, visit http://gerrit.ovirt.org/35444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c95db55a56b7a81ae81876e57426fd167bc0545 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
