Alon Bar-Lev has posted comments on this change. Change subject: core : Introduce engine_sessions table and DAO ......................................................................
Patch Set 5: (2 comments) http://gerrit.ovirt.org/#/c/35148/5/packaging/dbscripts/engine_sessions_sp.sql File packaging/dbscripts/engine_sessions_sp.sql: Line 25: Line 26: END; $procedure$ Line 27: LANGUAGE plpgsql; Line 28: Line 29: Create or replace FUNCTION GetEngineSessionBySessionId(v_engine_session_id text) RETURNS SETOF engine_sessions STABLE so we do not need this one, right? Line 30: AS $procedure$ Line 31: BEGIN Line 32: RETURN QUERY SELECT * Line 33: FROM engine_sessions Line 49: Line 50: END; $procedure$ Line 51: LANGUAGE plpgsql; Line 52: Line 53: Create or replace FUNCTION DeleteEngineSessionBySessionId(v_engine_session_id text) and we do not need this one, right? Line 54: RETURNS integer Line 55: AS $procedure$ Line 56: DECLARE Line 57: deleted_rows int; -- To view, visit http://gerrit.ovirt.org/35148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4b4d9cfc3edc6084fc0436ecfd09c82d5ae57f5e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
