Eli Mesika has posted comments on this change. Change subject: core: storage element missing DC id for search ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/35452/4/packaging/dbscripts/common_sp.sql File packaging/dbscripts/common_sp.sql: Line 623: CREATE OR REPLACE FUNCTION fn_db_first_agg ( anyelement, anyelement ) Line 624: RETURNS anyelement LANGUAGE sql IMMUTABLE STRICT AS $$ Line 625: SELECT $1; Line 626: $$; Line 627: DROP AGGREGATE IF EXISTS fn_db_first(anyelement); It is the responsibility of the DB upgrade to clean all of the aggregates in the same manner it drops views & SPs I will add support for that , please remove the DROP from this one ..... Line 628: CREATE AGGREGATE fn_db_first ( Line 629: sfunc = fn_db_first_agg, Line 630: basetype = anyelement, Line 631: stype = anyelement -- To view, visit http://gerrit.ovirt.org/35452 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2277ab4ab3a27cf81881ac2ec922bb0c3483ea19 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
