Roy Golan has posted comments on this change. Change subject: core: monitoring - Host Monitoring handles Vms Monitoring exeption ......................................................................
Patch Set 17: (1 comment) http://gerrit.ovirt.org/#/c/27922/17/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/HostMonitoring.java: Line 134: if (vds.getStatus() != VDSStatus.PreparingForMaintenance && vds.getStatus() != VDSStatus.Maintenance) { Line 135: ResourceManager.getInstance().runVdsCommand(VDSCommandType.SetVdsStatus, Line 136: new SetVdsStatusVDSCommandParameters(vds.getId(), VDSStatus.Error)); Line 137: } Line 138: } catch (VDSNetworkException e) { > i dont understand why you added this here, yes the last patch covers it and also removes this rethrowing Line 139: saveVdsDynamic = vdsManager.handleNetworkException(e, vds); Line 140: throw e; Line 141: } catch (Throwable t) { Line 142: log.error("Failure to refresh Vds runtime info: {}", t.getMessage()); -- To view, visit http://gerrit.ovirt.org/27922 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1fb98b6f05fa6f3bb02c59f5217e46c93c3b6875 Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <[email protected]> Gerrit-Reviewer: Liran Zelkha <[email protected]> Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
