Liron Aravot has posted comments on this change. Change subject: core: set Disk Profile for cloned VM from snapshot ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35205/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java: Line 198: clonedDiskImage.setVolumeType(srcDiskImage.getVolumeType()); Line 199: ArrayList<Guid> storageIds = new ArrayList<Guid>(); Line 200: storageIds.add(storageDomainId); Line 201: clonedDiskImage.setStorageIds(storageIds); Line 202: clonedDiskImage.setDiskProfileId(diskProfileId); is there a reason to not have it DiskImage.copyOf? Line 203: Line 204: // If volume information was changed at client , use its volume information. Line 205: // If volume information was not changed at client - use the volume information of the ancestral image Line 206: if (diskInfoDestinationMap != null && diskInfoDestinationMap.containsKey(srcDiskImage.getId())) { http://gerrit.ovirt.org/#/c/35205/1/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 3143: @DefaultStringValue("Cannot ${action} ${type}. Profile is in use.") Line 3144: String ACTION_TYPE_FAILED_PROFILE_IN_USE(); Line 3145: Line 3146: @DefaultStringValue("Cannot ${action} ${type}. Disk Profile is empty.") Line 3147: String ACTION_TYPE_DISK_PROFILE_EMPTY(); please seperate this part of a different patch...this missing message isn't relevant only to that flow. Line 3148: Line 3149: @DefaultStringValue("Cannot ${action} ${type}. Disk Profile wasn't found.") Line 3150: String ACTION_TYPE_FAILED_DISK_PROFILE_NOT_FOUND(); Line 3151: -- To view, visit http://gerrit.ovirt.org/35205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5f79e853a1482ccabf6c287d663da87ab332fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
