Shubhendu Tripathi has posted comments on this change. Change subject: webadmin: UI to list the no of gluster volume snapshots ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/35305/8/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java: Line 1648: Frontend.getInstance().runQuery(VdcQueryType.GetGlusterVolumeRebalanceStatus, parameters, aQuery); Line 1649: } Line 1650: Line 1651: public void getEngineTimeStamp(AsyncQuery aQuery) { Line 1652: aQuery.setHandleFailure(true); > 1. Not sure if its ok to error on failure to get engine time stamp. Checked with Kanagaraj as well. He also feels that this check is not required and simple we can call the query. Will change accordingly. Line 1653: Frontend.getInstance().runQuery(VdcQueryType.GetEngineTimestamp, new VdcQueryParametersBase(), aQuery); Line 1654: } Line 1655: Line 1656: public void getGlusterVolumeProfilingStatistics(AsyncQuery aQuery, Guid clusterId, Guid volumeId, boolean nfs) { http://gerrit.ovirt.org/#/c/35305/8/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVolumeView.java: Line 151: }), Line 152: constants.activitiesOnVolume(), Line 153: "100px"); //$NON-NLS-1$ Line 154: Line 155: getTable().addColumn(new GlusterVolumeSnapshotsCountColumn(), constants.noOfSnapshotsLabel(), "150px"); //$NON-NLS-1$ > I think 60px or 70px looks good. Ok. Will change accordingly and check it. The only thing is Column Label which is bigger ("No of snapshots"). Line 156: Line 157: getTable().addActionButton(new WebAdminButtonDefinition<GlusterVolumeEntity>(constants.newVolume()) { Line 158: @Override Line 159: protected UICommand resolveCommand() { -- To view, visit http://gerrit.ovirt.org/35305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I805a0d89833225a98018ae7124e9d4c6d7f743c0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
