Martin Mucha has posted comments on this change. Change subject: core,userportal,webadmin: improper construction of file path ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/29655/2//COMMIT_MSG Commit Message: Line 6: Line 7: core,userportal,webadmin: improper construction of file path Line 8: Line 9: replaced string joining with proper construct Line 10: added missing //$NON-NLS-1$ > Oh, and of course if you remove them from the dal file, this line is out-of Done Line 11: Line 12: Change-Id: Ifd073d100931003ab33cb6ea28df4260c7d5548a http://gerrit.ovirt.org/#/c/29655/2/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/DuplicateKeysTest.java: Line 10: Line 11: public class DuplicateKeysTest { Line 12: @Test Line 13: public void testDuplicateKeys() throws FileNotFoundException { Line 14: String baseDir = System.getProperty("basedir"); //$NON-NLS-1$ > Are these $NON-NLS-1$ flags required in the dal module? I don't think they Done Line 15: assumeNotNull(baseDir); Line 16: Line 17: String fileName = "AppErrors.properties"; //$NON-NLS-1$ Line 18: final File dir = new File(baseDir, "src/main/resources/bundles"); //$NON-NLS-1$ -- To view, visit http://gerrit.ovirt.org/29655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd073d100931003ab33cb6ea28df4260c7d5548a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Mucha <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
