Tomas Jelinek has uploaded a new change for review. Change subject: webadmin: Show disabled prestared field in New Pool Dialog ......................................................................
webadmin: Show disabled prestared field in New Pool Dialog In Edit Pool Dialog the "Prestarted" field is shown. This patch adds this field also to the New Pool Dialog. In the New Pool Dialog this field is disabled and has a title which explains the reason behind. Change-Id: I61534137a4aaa2b648729254376261737e532f66 Signed-off-by: Tomas Jelinek <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java 3 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/73/7173/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java index f4ae65e..df418e8 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java @@ -692,6 +692,9 @@ @DefaultStringValue("Prestarted") String prestartedPoolPopup(); + @DefaultStringValue("Prestarted VMs can only be edited once the pool is created") + String prestartedDisabledReason(); + // VM disk @DefaultStringValue("Size(GB)") String sizeVmDiskPopup(); diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java index 07f9a19..cd28fbe 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java @@ -886,4 +886,7 @@ TableStyle cellTableStyle(); } + public CommonApplicationConstants getConstants() { + return constants; + } } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java index bf8def5..0177f47 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolNewPopupWidget.java @@ -45,8 +45,9 @@ object.getNumOfDesktops().setEntity("1"); //$NON-NLS-1$ assignedVmsEditor.setVisible(false); numOfDesktopsEditor.setLabel(""); //$NON-NLS-1$ - prestartedVmsEditor.setVisible(false); - prestartedVmsHintLabel.setVisible(false); + prestartedVmsEditor.setVisible(true); + prestartedVmsEditor.setEnabled(false); + prestartedVmsEditor.setTitle(getConstants().prestartedDisabledReason()); } else { assignedVmsEditor.addLabelStyleName(style.assignedVmsLabel()); } -- To view, visit http://gerrit.ovirt.org/7173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I61534137a4aaa2b648729254376261737e532f66 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
