Alon Bar-Lev has posted comments on this change. Change subject: core: remove ConnectionWrapper ......................................................................
Patch Set 2: Code-Review+1 I still do not fully understand why the before/after in base is required but as long as we have plain URLConnection the provider can do whatever it chooses. an alternative implementation would be to split the runHttp in base into two, one that sends the request and the other that reads, this way the before after that is unique to foreman provider may be implemented in the provider. -- To view, visit http://gerrit.ovirt.org/35781 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e385f266837c7b45b0d5d1c02402e8ee9eb155 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
