Liron Aravot has uploaded a new change for review. Change subject: core: remove unneeded setSucceeded ......................................................................
core: remove unneeded setSucceeded The following code in the started thread is executed after the tasks were cleared, therefore there's no need to execute setSucceeded, furthermore, as the class isn't thread safe it's risky to have that call in terms of future changes. Change-Id: I2d15162aded39cf43064b14fd6c02644bf95936f Signed-off-by: Liron Aravot <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/35814/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java index 2472558..f028ebb 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainWithOvfUpdateCommand.java @@ -186,7 +186,6 @@ executeDeactivateCommnad(false); ctx.resetCompensation(); } catch (Exception e) { - setSucceeded(false); log.error("Error when attempting to deactivate storage domain {}", getStorageDomainId(), e); compensate(); } -- To view, visit http://gerrit.ovirt.org/35814 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d15162aded39cf43064b14fd6c02644bf95936f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
