Omer Frenkel has posted comments on this change. Change subject: core: vdsm -> engine communication for spicevnc ......................................................................
Patch Set 52: (1 comment) http://gerrit.ovirt.org/#/c/28572/52/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java: Line 160: return lunsMap; Line 161: } Line 162: Line 163: public static void updateVMDynamicData(VmDynamic vm, Map<String, Object> xmlRpcStruct) { Line 164: updateVMDynamicDataOverridenDisplay(vm, null, xmlRpcStruct); why do we need another method? also the name is not so good because it handles more than just the display Line 165: } Line 166: Line 167: public static void updateVMDynamicDataOverridenDisplay(VmDynamic vm, VDS vds, Map<String, Object> xmlRpcStruct) { Line 168: if (xmlRpcStruct.containsKey(VdsProperties.vm_guid)) { -- To view, visit http://gerrit.ovirt.org/28572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb38b68ba5a49238d4f9d9cce8475f6af9180077 Gerrit-PatchSet: 52 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
