Omer Frenkel has posted comments on this change. Change subject: engine: Adjust console ticket commands ......................................................................
Patch Set 56: (2 comments) http://gerrit.ovirt.org/#/c/28574/56/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetVmTicketVDSCommandParameters.java: Line 45: } Line 46: Line 47: @Override Line 48: public String toString() { Line 49: return String.format("%s, ticket=%s, validTime=%s,m userName=%s, userId=%s", super.toString(), getTicket(), getValidTime(), please somehow print the new parameter.. Line 50: getUserName(), getUserId()); Line 51: } http://gerrit.ovirt.org/#/c/28574/56/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetVmTicketVDSCommand.java: Line 40: devStruct.put("deviceType", "graphics"); Line 41: devStruct.put("graphicsType", getParameters().getGraphicsType().name().toLowerCase()); Line 42: devStruct.put("password", getParameters().getTicket()); Line 43: devStruct.put("ttl", getParameters().getValidTime()); Line 44: devStruct.put("existingConnAction", connectionAction); what about userName and userId, i think there is a vdsm hook that might expect it... Line 45: Line 46: status = getBroker().vmUpdateDevice(getParameters().getVmId().toString(), devStruct); Line 47: } Line 48: -- To view, visit http://gerrit.ovirt.org/28574 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62c9e29349a58156cddba1ca039cf9b7f14e610 Gerrit-PatchSet: 56 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Frank Kobzik <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Frank Kobzik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
