Allon Mureinik has posted comments on this change.
Change subject: core: user query for quota (#847511)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Please add tests for the added filtering functionality.
also, see questions inline.
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java
Line 152: * general (i.e., defined on the storage pool containing the
storage).<br/>
Line 153: * <b>Note:</b> The quotas returned are <b>thin</b> objects,
containing only the metadata of the quota,
Line 154: * not the usage data.
Line 155: */
Line 156: public List<Quota> getAllRelevantQuotasForStorage(Guid storageId,
Guid userID, boolean isFiltered);
don't you have an admin flavor of this method?
or are we always calling it with these additional parameters?
Line 157:
Line 158: /**
Line 159: * Returns a list of all the quotas that are relevant to the
given {@link #vdsGroupId} -
Line 160: * be it specific quotas (i.e., defined directly on the VDS
Group) or
Line 161: * general (i.e., defined on the storage pool containing the
group).<br/>
Line 162: * <b>Note:</b> The quotas returned are <b>thin</b> objects,
containing only the metadata of the quota,
Line 163: * not the usage data.
Line 164: */
Line 165: public List<Quota> getAllRelevantQuotasForVdsGroup(Guid
vdsGroupId, Guid userID, boolean isFiltered);
same
Line 166:
Line 167: /**
Line 168: * Is the Quota in use by any Image or VM (checks only for
existence of the quota id in
Line 169: * the 'vm_static' and 'images' tables).
--
To view, visit http://gerrit.ovirt.org/7183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0b7fc712c742c90087e2b4b138b9ade37cf8668
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
