Alon Bar-Lev has posted comments on this change. Change subject: core : Remove quartz job to SyncUsers ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/35893/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-04 13:45:57 -0500 Line 4: Commit: Ravi Nori <[email protected]> Line 5: CommitDate: 2014-12-04 17:13:49 -0500 Line 6: Line 7: core : Remove quartz job to SyncUsers aaa: remove user sync ? Line 8: Line 9: Since all queries are performed using the engine sessions Line 10: table, the users groups are always derived from the principal Line 11: on user login there is no need to periodically sync users. http://gerrit.ovirt.org/#/c/35893/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDbGroupsByUserIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDbGroupsByUserIdQuery.java: Line 42: Arrays.asList(dbUser.getExternalId()), Line 43: true, Line 44: true); Line 45: if (!principalRecords.isEmpty()) { Line 46: directoryUser = DirectoryUtils.mapPrincipalRecordToDbUser(dbUser.getDomain(), principalRecords.iterator().next()); this function is not good for as as it goes to database, while better to just present everything within the principal record flatten. I would like to see all groups if we can, so maybe just go over the principal record and extract group names? Line 47: directoryUser.setAdmin(dbUser.isAdmin()); Line 48: directoryUser.setActive(dbUser.isActive()); Line 49: } Line 50: } catch (Exception ex) { -- To view, visit http://gerrit.ovirt.org/35893 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15248a628647430d7f3d22e68e66456caffbcb40 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
