Alexander Wels has uploaded a new change for review. Change subject: engine: fix findbug warning in ResourceManager ......................................................................
engine: fix findbug warning in ResourceManager - Findbugs is reporting a warning in ResourceManager this patch fixes the warning. Change-Id: I7ce68974540186251939e984add851d2c5d8789f Signed-off-by: Alexander Wels <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/35903/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java index 281998e..da8ca4c 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java @@ -65,7 +65,7 @@ private final Map<Guid, VdsManager> vdsManagersDict = new ConcurrentHashMap<>(); private final Set<Guid> asyncRunningVms = Collections.newSetFromMap(new ConcurrentHashMap<Guid, Boolean>()); - private ConcurrentHashMap<Guid, VmManager> vmManagers = new ConcurrentHashMap<>(); + private final ConcurrentHashMap<Guid, VmManager> vmManagers = new ConcurrentHashMap<>(); private static final String VDSCommandPrefix = "VDSCommand"; @@ -84,10 +84,14 @@ return instance; } + private static void setInstance(ResourceManager manager) { + instance = manager; + } + @PostConstruct private void init() { // init the singleton. TODO remove once all code is using CDI - instance = this; + setInstance(this); log.info("Start initializing {}", getClass().getSimpleName()); List<VDS> allVdsList = DbFacade.getInstance().getVdsDao().getAll(); HashSet<Guid> nonResponsiveVdss = new HashSet<Guid>(); -- To view, visit http://gerrit.ovirt.org/35903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ce68974540186251939e984add851d2c5d8789f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
