Allon Mureinik has posted comments on this change. Change subject: core: Command refactoring. ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35788/1//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-11-30 17:09:21 +0200 Line 4: Commit: Amit Aviram <[email protected]> Line 5: CommitDate: 2014-12-02 11:28:55 +0200 Line 6: Line 7: core: Command refactoring. Please ad the command's name here. At first glance, this description makes the patch look like an infra patch :-) Line 8: Line 9: UpdateStoragePoolCommand's CDA was refactored to fit the CDA style in Line 10: the system. as a side effect this makes the code a bit more efficient Line 11: since once a validation fails within the CDA it makes the function http://gerrit.ovirt.org/#/c/35788/1/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java: Line 94: doReturn(vdsGroupDao).when(cmd).getVdsGroupDAO(); Line 95: doReturn(vdsDao).when(cmd).getVdsDAO(); Line 96: doReturn(networkDao).when(cmd).getNetworkDAO(); Line 97: doReturn(validator).when(cmd).createStoragePoolValidator(); Line 98: doReturn(true).when(sdList).isEmpty(); > Basically the refactoring didn't change the results of the tests. still- th arg... why mock a list in the first place? Won't it be easier to just define it as a new ArrayList<>()? Line 99: Line 100: mcr.mockConfigValue(ConfigValues.AutoRegistrationDefaultVdsGroupID, DEFAULT_VDS_GROUP_ID); Line 101: mcr.mockConfigValue(ConfigValues.ManagementNetwork, "test_mgmt"); Line 102: mcr.mockConfigValue(ConfigValues.NonVmNetworkSupported, false); -- To view, visit http://gerrit.ovirt.org/35788 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icd0c28eb86af753a7e48e845da23fc5feca2019a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
