Allon Mureinik has posted comments on this change. Change subject: engine: Addition to ReplacementUtils ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/35915/1/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java File backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ReplacementUtils.java: Line 10: Line 11: public class ReplacementUtils { Line 12: Line 13: protected static final int DEFAULT_MAX_NUMBER_OF_PRINTED_ITEMS = 5; Line 14: protected static final String DEFAULT_SEPARATOR = ",\n"; how about "," + System.getProperty("line.separator") ? Line 15: Line 16: /** Line 17: * Replace a property defined within a message with a bounded number of elements.<br> Line 18: * In addition, if a counter appears in the message, it will be replaced with the elements size:<br> http://gerrit.ovirt.org/#/c/35915/1/backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ReplacementUtilsTest.java: Line 101: Line 102: for (int i = 0; i < ReplacementUtils.DEFAULT_MAX_NUMBER_OF_PRINTED_ITEMS * 2; i++) { Line 103: items.add(buildPropertyValue(i)); Line 104: } Line 105: What about a test for the new behavior you added? Line 106: return items; Line 107: } Line 108: Line 109: private String buildPropertyValue(int id) { -- To view, visit http://gerrit.ovirt.org/35915 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I77f64b31b69574aff68a0706dd7d6afa3037511a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Lior Vernia <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
