Maor Lipchuk has posted comments on this change. Change subject: core: Add support for copied disk template ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/35933/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateFromConfigurationCommand.java: Line 110: } Line 111: Line 112: private void setCopiedImages() { Line 113: List<OvfEntityData> ovfEntityDataList = Line 114: getUnregisteredOVFDataDao().getByEntityIdAndStorageDomain(ovfEntityData.getEntityId(), null); > Formatting: the indentation here is wrong. it should not be wrong, this is already after format Line 115: List<DiskImage> copiedImagesList = initializeListForCopiedImage(); Line 116: for (OvfEntityData ovfEntityDataFetched : ovfEntityDataList) { Line 117: setValidCopiedStorageDomain(copiedImagesList, getImages(), ovfEntityDataFetched.getStorageDomainId()); Line 118: } Line 119: insertNewCopiedDiskImage(copiedImagesList); Line 120: } Line 121: Line 122: private List<DiskImage> initializeListForCopiedImage() { Line 123: List<DiskImage> clonedDiskImages = (ArrayList)getImages().clone(); > Yikes. Why not just new ArrayList<>(getImages()) ? done Line 124: ArrayList<Guid> storageDomains = new ArrayList<>(); Line 125: for (DiskImage clonedDiskImage : clonedDiskImages) { Line 126: clonedDiskImage.setStorageIds(storageDomains); Line 127: } Line 127: } Line 128: return clonedDiskImages; Line 129: } Line 130: Line 131: private void setValidCopiedStorageDomain(List<DiskImage> copiedImagesList,List<DiskImage> originalmages, Guid StorageDomainId) { > conventions - storageDomainId. done Line 132: List<DiskImage> clonedDiskImages = (ArrayList)getImages().clone(); Line 133: int index = 0; Line 134: for (DiskImage clonedDiskImage : clonedDiskImages) { Line 135: if (originalmages.get(index).getStorageIds().get(0).equals(StorageDomainId)) { Line 128: return clonedDiskImages; Line 129: } Line 130: Line 131: private void setValidCopiedStorageDomain(List<DiskImage> copiedImagesList,List<DiskImage> originalmages, Guid StorageDomainId) { Line 132: List<DiskImage> clonedDiskImages = (ArrayList)getImages().clone(); > same here done Line 133: int index = 0; Line 134: for (DiskImage clonedDiskImage : clonedDiskImages) { Line 135: if (originalmages.get(index).getStorageIds().get(0).equals(StorageDomainId)) { Line 136: continue; -- To view, visit http://gerrit.ovirt.org/35933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7514146d26792a361e47d1de820f5233ff9bf40 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
