Roy Golan has posted comments on this change. Change subject: engine : Query to fetch list of volumes eligible for geo replication ......................................................................
Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/33845/22/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/GlusterGeoRepUtil.java: Line 15: import org.ovirt.engine.core.dao.VdsGroupDAO; Line 16: import org.ovirt.engine.core.dao.gluster.GlusterGeoRepDao; Line 17: import org.ovirt.engine.core.utils.linq.Predicate; Line 18: Line 19: public class GlusterGeoRepUtil { > Please consider having this injected using CDI, correct me if I'm wrong, this tool is static helper methods in effect. it doesn't hold any state right? if that's the case I'd change all the methods to static and just keep it a helper. DbFacade could be injected using the Injector.java helper class Line 20: Line 21: private static GlusterGeoRepUtil instance = new GlusterGeoRepUtil(); Line 22: Line 23: public static GlusterGeoRepUtil getInstance() { -- To view, visit http://gerrit.ovirt.org/33845 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0fc3ecb15535181f1ca2a8780461cb89788a3f41 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Ramesh N <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Shubhendu Tripathi <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: anmolbabu <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
