Liron Aravot has posted comments on this change. Change subject: core: Increment DB Generation when image is copied ......................................................................
Patch Set 3: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/35932/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java: Line 276: if (getParameters().getOperation() == ImageOperation.Copy) { Line 277: getVmStaticDAO().incrementDbGeneration(getVmTemplateId()); Line 278: } else { Line 279: List<Pair<VM, VmDevice>> vmsForDisk = getVmsWithVmDeviceInfoForDiskId(); Line 280: for (Pair<VM, VmDevice> pair : vmsForDisk) { I don't really like that we update each vm that the disk is plugged to, even if it's not contained in it's ovf..but that an issue also on other flows. Let's solve it for all together. Line 281: getVmStaticDAO().incrementDbGeneration(pair.getFirst().getId()); Line 282: } Line 283: } Line 284: } -- To view, visit http://gerrit.ovirt.org/35932 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icdd5e02387fe729195bd4b3c502636671a914e5d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
