Ayal Baron has posted comments on this change.
Change subject: core: attach of Illegal disk should not be allowed (#848074)
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 78:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_POOL_NOT_MATCH);
Line 79: }
Line 80: if (retValue && disk.getDiskStorageType() ==
DiskStorageType.IMAGE) {
Line 81: retValue = validate(new
SnapshotsValidator().vmNotDuringSnapshot(getVm().getId()));
Line 82: if (((DiskImage) disk).getimageStatus() ==
ImageStatus.ILLEGAL) {
This check should be the first thing we check.
Need to define a boolean isDiskImage = disk.getDiskStorageType() ==
DiskStorageType.IMAGE
Line 83: retValue = false;
Line 84:
addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_ILLEGAL_DISK_OPERATION);
Line 85: }
Line 86: }
....................................................
File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
Line 261: VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL=$hostStatus Up,
Maintenance or Non operational
Line 262:
Line 263: ACTION_TYPE_FAILED_DISK_ALREADY_ATTACHED=Cannot ${action} ${type}.
The disk is already attached to VM.
Line 264: ACTION_TYPE_FAILED_DISK_ALREADY_DETACHED=Cannot ${action} ${type}.
The disk is already detached from VM.
Line 265: ACTION_TYPE_FAILED_ILLEGAL_DISK_OPERATION=Cannot ${action} ${type}.
Disk is at Illegal. Illegal disk can only be deleted.
s/Disk is at Illegal/Disk is illegal/
s/Illegal disk/Illegal disks/
Line 266: ACTION_TYPE_FAILED_VM_MAX_RESOURCE_EXEEDED=Cannot ${action} ${type}.
Maximum value for concurrently running VMs exceeded.
Line 267: ACTION_TYPE_FAILED_CPU_NOT_FOUND=Cannot ${action} ${type}. The chosen
CPU is not supported.
Line 268: ACTION_TYPE_FAILED_EXCEEDED_MAX_PCI_SLOTS=Cannot ${action} ${type}.
Maximum PCI devices exceeded.
Line 269: ACTION_TYPE_FAILED_EXCEEDED_MAX_IDE_SLOTS=Cannot ${action} ${type}.
Maximum IDE devices exceeded.
--
To view, visit http://gerrit.ovirt.org/7205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35fe4123c40de371a6f338bc3655923ab51400e1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
