Yair Zaslavsky has posted comments on this change.

Change subject: https://bugzilla.redhat.com/show_bug.cgi?id=818479
......................................................................


Patch Set 5: (1 inline comment)

....................................................
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResult.java
Line 72:         }
Line 73:     }
Line 74: 
Line 75:     public ManageDomainsResult(ManageDomainsResultEnum enumResult, 
String... params) {
Line 76:         this("Default error.", enumResult, params);
Should be blank or null, not "Default error"
Line 77:     }
Line 78: 
Line 79:     public int getExitCode() {
Line 80:         return exitCode;


--
To view, visit http://gerrit.ovirt.org/7202
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If21f117208a53a80ebfefbbe4f6a0c188e35a3bd
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to