Eli Mesika has posted comments on this change. Change subject: core: Upload only the DC diskless VMs/Templates to OVF stores ......................................................................
Patch Set 2: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/35943/2/packaging/dbscripts/vms_sp.sql File packaging/dbscripts/vms_sp.sql: Line 610: INNER JOIN base_disks i Line 611: ON i.disk_id = vd.device_id Line 612: AND vd.snapshot_id IS NULL Line 613: WHERE i.shareable = v_shareable) Line 614: AND vs.vds_group_id IN (SELECT vg.vds_group_id > Why not selecting directly from the vds view and save this redundant nested ignore Line 615: FROM vds_groups vg, storage_pool sp Line 616: WHERE vg.storage_pool_id = v_storage_pool_id); Line 617: END; $procedure$ Line 618: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/35943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51689cdf0479548c8c4be1267d478fcb8f89de0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
