Moti Asayag has posted comments on this change.
Change subject: engine: Added audit log to update network (#846241)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
thanks kublin,
but in this case there are 2 non-network related issues that should be fix.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
Line 465: NETWORK_ADD_NETWORK_FAILED(943),
Line 466: NETWORK_REMOVE_NETWORK(944),
Line 467: NETWORK_REMOVE_NETWORK_FAILED(945),
Line 468: NETWORK_UPDATE_NETWORK(1111),
Line 469: NETWORK_UPDATE_NETWORK_FAILED(1112),
this enum ordinal already taken by:
NETWORK_UPDTAE_NETWORK_ON_CLUSTER(1112)
please assign unique value for it.
Line 470: NETWORK_ATTACH_NETWORK_TO_VDS_GROUP(946),
Line 471: NETWORK_ATTACH_NETWORK_TO_VDS_GROUP_FAILED(947),
Line 472: NETWORK_DETACH_NETWORK_TO_VDS_GROUP(948),
Line 473: NETWORK_DETACH_NETWORK_TO_VDS_GROUP_FAILED(949),
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 421: NETWORK_UPDTAE_NETWORK_ON_CLUSTER=Network ${NetworkName} on Cluster
${VdsGroupName} updated.
Line 422: NETWORK_UPDTAE_NETWORK_ON_CLUSTER_FAILED=Failed to update Network
${NetworkName} on Cluster ${VdsGroupName}.
Line 423: NETWORK_REMOVE_NETWORK=Network ${NetworkName} was removed from data
center: ${StoragePoolName}
Line 424: NETWORK_REMOVE_NETWORK_FAILED=Failed to remove Network ${NetworkName}
from data center: ${StoragePoolName}
Line 425: NETWORK_UPDATE_NETWORK=Network ${NetworkName} was updated on data
center: ${StoragePoolName}
s/data center/Data Center
Line 426: NETWORK_UPDATE_NETWORK_FAILED=Failed to update Network ${NetworkName}
on data center: ${StoragePoolName}
Line 427: NETWORK_REMOVE_TEMPLATE_INTERFACE=Interface ${InterfaceName}
(${InterfaceType}) was removed from Template ${VmTemplateName}. (User:
${UserName})
Line 428: NETWORK_REMOVE_TEMPLATE_INTERFACE_FAILED=Failed to remove Interface
${InterfaceName} (${InterfaceType}) from Template ${VmTemplateName}. (User:
${UserName})
Line 429: NETWORK_REMOVE_VM_INTERFACE=Interface ${InterfaceName}
(${InterfaceType}) was removed from VM ${VmName}. (User: ${UserName})
Line 422: NETWORK_UPDTAE_NETWORK_ON_CLUSTER_FAILED=Failed to update Network
${NetworkName} on Cluster ${VdsGroupName}.
Line 423: NETWORK_REMOVE_NETWORK=Network ${NetworkName} was removed from data
center: ${StoragePoolName}
Line 424: NETWORK_REMOVE_NETWORK_FAILED=Failed to remove Network ${NetworkName}
from data center: ${StoragePoolName}
Line 425: NETWORK_UPDATE_NETWORK=Network ${NetworkName} was updated on data
center: ${StoragePoolName}
Line 426: NETWORK_UPDATE_NETWORK_FAILED=Failed to update Network ${NetworkName}
on data center: ${StoragePoolName}
s/data center/Data Center
Line 427: NETWORK_REMOVE_TEMPLATE_INTERFACE=Interface ${InterfaceName}
(${InterfaceType}) was removed from Template ${VmTemplateName}. (User:
${UserName})
Line 428: NETWORK_REMOVE_TEMPLATE_INTERFACE_FAILED=Failed to remove Interface
${InterfaceName} (${InterfaceType}) from Template ${VmTemplateName}. (User:
${UserName})
Line 429: NETWORK_REMOVE_VM_INTERFACE=Interface ${InterfaceName}
(${InterfaceType}) was removed from VM ${VmName}. (User: ${UserName})
Line 430: NETWORK_REMOVE_VM_INTERFACE_FAILED=Failed to remove Interface
${InterfaceName} (${InterfaceType}) from VM ${VmName}. (User: ${UserName})
--
To view, visit http://gerrit.ovirt.org/7219
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5743f143c596c1ea57e2a45c54324dbd04876d70
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
