Michal Skrivanek has posted comments on this change.

Change subject: core: fixed NPE when vdsm returns emtpy balloon info
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.ovirt.org/#/c/36016/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java:

Line 331:     private void proceedBalloonCheck() {
Line 332:         if (getVdsManager().getCopyVds().isBalloonEnabled()) {
Line 333:             VmBalloonInfo balloonInfo = 
vdsmVm.getVmStatistics().getVmBalloonInfo();
Line 334: 
Line 335:             /* first time we check or we're not getting the balloon 
info
the english here looks weird...
Line 336:                from vdsm rhbz#1171491
Line 337:              */
Line 338:             if (balloonInfo.getBalloonLastMemory() == null) {
Line 339:                 
balloonInfo.setBalloonLastMemory(balloonInfo.getCurrentMemory());


-- 
To view, visit http://gerrit.ovirt.org/36016
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I27e7d3eacfa2807e9f4b058473ae898956dabb01
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Jiří Moskovčák <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to