Shahar Havivi has posted comments on this change. Change subject: ui: RFE add custom UUID for VM ......................................................................
Patch Set 3: (5 comments) http://gerrit.ovirt.org/#/c/35970/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java: Line 193: Line 194: @UiField Line 195: @Path(value = "vmId.entity") Line 196: @WithElementId("vmId") Line 197: public StringEntityModelTextBoxEditor vmIdEditor; > well, this seems to be quite advanced thing so I think it should be availab Done Line 198: Line 199: @UiField(provided = true) Line 200: @Path(value = "description.entity") Line 201: @WithElementId("description") http://gerrit.ovirt.org/#/c/35970/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java: Line 44: super.initialize(systemTreeSelectedItem); Line 45: Line 46: getModel().getIsSoundcardEnabled().setIsChangable(true); Line 47: Line 48: getModel().getVmId().setIsChangable(false); > do you need this? the VmModelBehaviorBase already sets it. But anyway, plea I know, but from some reason it was editable for pool until I added this line... btw, how do we hide the control? Line 49: Line 50: getModel().getDisksAllocationModel().setIsVolumeFormatAvailable(false); Line 51: getModel().getDisksAllocationModel().setIsAliasChangable(true); Line 52: http://gerrit.ovirt.org/#/c/35970/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java: Line 2655: : AsyncDataProvider.getInstance().getMaxVmNameLengthNonWin()), Line 2656: isValidTab(TabName.POOL_TAB) ? new PoolNameValidation() : new I18NNameValidation() Line 2657: }); Line 2658: Line 2659: getValid().setIsValid(true); > this flag is properly set right before this method returns - no need to set Done Line 2660: if (getVmId().getIsAvailable() && !StringHelper.isNullOrEmpty(getVmId().getEntity())) { Line 2661: getVmId().validateEntity(new IValidation[] { new GuidValidation() }); Line 2662: } Line 2663: http://gerrit.ovirt.org/#/c/35970/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java: Line 2117: model.startProgress(null); Line 2118: Line 2119: VM vm = getcurrentVm(); Line 2120: if (!StringHelper.isNullOrEmpty(model.getVmId().getEntity())) { Line 2121: vm.setId(new Guid(model.getVmId().getEntity())); > you need this part also in UserPortalListModel Done Line 2122: } Line 2123: vm.setUseLatestVersion(model.getTemplate().getSelectedItem() instanceof LatestVmTemplate); Line 2124: Line 2125: AddVmParameters parameters = new AddVmParameters(vm); http://gerrit.ovirt.org/#/c/35970/3/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/GuidValidation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/GuidValidation.java: Line 5: public class GuidValidation extends RegexValidation Line 6: { Line 7: public GuidValidation() Line 8: { Line 9: setExpression("^[0-9a-f]{8,8}-[0-9a-f]{4,4}-[0-9a-f]{4,4}-[0-9a-f]{4,4}-[0-9a-f]{12,12}$"); //$NON-NLS-1$ > IIUC this will match only lower case a-f, but guid can have also upper case Done Line 10: setMessage(ConstantsManager.getInstance().getConstants().invalidGuidMsg()); Line 11: } -- To view, visit http://gerrit.ovirt.org/35970 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia13e212369c070d800bfe5a1bb71f1ca5c875fd6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: Tomas Jelinek <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
