Arik Hadas has posted comments on this change. Change subject: core: fixed NPE when vdsm returns empty balloon info ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/36016/4/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmAnalyzer.java: Line 340: return; Line 341: } Line 342: Line 343: Guid vmId = vdsmVm.getVmDynamic().getId(); Line 344: if (dbVm == null) { this patch can be shortened to one line right? I don't see why changing the order of the if statements. please only add the null check to the if-clause Line 345: return; Line 346: } Line 347: Line 348: if (isBalloonDeviceActiveOnVm(vdsmVm) -- To view, visit http://gerrit.ovirt.org/36016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I27e7d3eacfa2807e9f4b058473ae898956dabb01 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Jiří Moskovčák <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
