Greg Padgett has uploaded a new change for review. Change subject: core: Fix coverity issue - possible NPE ......................................................................
core: Fix coverity issue - possible NPE Coverity found a possible null object dereference in a recent live merge patch. Even though business logic would prevent it from occurring, fixing it will make coverity happy. Change-Id: I90b8b8caf8b506f1ba5f3dfc0604cce523e87cac Signed-off-by: Greg Padgett <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/36072/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java index 9c9811a..66c9f04 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskSnapshotsCommandCallback.java @@ -31,7 +31,7 @@ break; default: CommandEntity cmdEntity = CommandCoordinatorUtil.getCommandEntity(childCmdId); - if (cmdEntity.isCallBackNotified()) { + if (cmdEntity != null && cmdEntity.isCallBackNotified()) { ++completedChildren; break; } else { -- To view, visit http://gerrit.ovirt.org/36072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I90b8b8caf8b506f1ba5f3dfc0604cce523e87cac Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
