Alon Bar-Lev has posted comments on this change. Change subject: engine : Retrieve user groups from directory server ......................................................................
Patch Set 1: (7 comments) http://gerrit.ovirt.org/#/c/36083/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java: Line 78: returnValue = searchAuditLogEvents(); Line 79: break; Line 80: } Line 81: case DBUser: { Line 82: returnValue = UserGroupUtil.retrieveUserAdGroups(searchDbUsers()); why do we need groups in search? Line 83: break; Line 84: } Line 85: case DBGroup: { Line 86: returnValue = searchDbGroups(); http://gerrit.ovirt.org/#/c/36083/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserByUserIdQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/aaa/GetDbUserByUserIdQuery.java: Line 14: @Override Line 15: protected void executeQueryCommand() { Line 16: getQueryReturnValue().setReturnValue( Line 17: UserGroupUtil.retrieveUserAdGroups(DbFacade.getInstance().getDbUserDao() Line 18: .get((getParameters()).getId(), getParameters().isFiltered()))); will this effect more than just restapi? Line 19: } http://gerrit.ovirt.org/#/c/36083/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/UserGroupUtil.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/UserGroupUtil.java: Line 1: package org.ovirt.engine.core.bll.utils; please move to bll.aaa. Line 2: Line 3: import org.ovirt.engine.core.bll.Backend; Line 4: import org.ovirt.engine.core.common.businessentities.aaa.AuthzGroup; Line 5: import org.ovirt.engine.core.common.businessentities.aaa.DbUser; Line 13: import java.util.TreeSet; Line 14: Line 15: public class UserGroupUtil { Line 16: Line 17: public static List<DbUser> retrieveUserAdGroups(List<DbUser> dbUsers) { why active directory? :) Line 18: for (DbUser dbUser : dbUsers) { Line 19: retrieveUserAdGroups(dbUser); Line 20: } Line 21: return dbUsers; Line 20: } Line 21: return dbUsers; Line 22: } Line 23: Line 24: public static DbUser retrieveUserAdGroups(DbUser dbUser) { why active directory? :) Line 25: if (!dbUser.getDomain().equals("internal")) { Line 26: VdcQueryReturnValue retVal = Backend.getInstance().runInternalQuery( Line 27: VdcQueryType.GetAuthzGroupsByUserId, Line 28: new IdQueryParameters(dbUser.getId())); Line 21: return dbUsers; Line 22: } Line 23: Line 24: public static DbUser retrieveUserAdGroups(DbUser dbUser) { Line 25: if (!dbUser.getDomain().equals("internal")) { there should be nothing special in internal, the core should not be aware of any special extension. Line 26: VdcQueryReturnValue retVal = Backend.getInstance().runInternalQuery( Line 27: VdcQueryType.GetAuthzGroupsByUserId, Line 28: new IdQueryParameters(dbUser.getId())); Line 29: if (retVal.getSucceeded()) { Line 30: Set<String> groupNames = new TreeSet<>(); Line 31: for (AuthzGroup group : (Collection<AuthzGroup>) retVal.getReturnValue()) { Line 32: groupNames.add(group.getName()); Line 33: } Line 34: dbUser.setGroupNames(groupNames); no group id within restapi? Line 35: } Line 36: } Line 37: return dbUser; Line 38: } -- To view, visit http://gerrit.ovirt.org/36083 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ec0af970f07dbbee943f2879a93ca61b1bccf94 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
