Shahar Havivi has posted comments on this change. Change subject: restapi: Avoid NPE when enum has no value ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/36080/1/backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/EnumValidator.java File backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/EnumValidator.java: Line 83: Line 84: public static <E extends Enum<E>> E validateEnum(String reason, String detail, Class<E> clz, String name, boolean toUppercase) { Line 85: try { Line 86: return Enum.valueOf(clz, toUppercase ? name.toUpperCase() : name); Line 87: } catch (IllegalArgumentException|NullPointerException e) { Do we want to limit to java 7? Line 88: detail = detail + getPossibleValues(clz); Line 89: throw new WebApplicationException(response(reason, MessageFormat.format(detail, name, clz.getSimpleName()))); Line 90: } Line 91: } -- To view, visit http://gerrit.ovirt.org/36080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8e2ba41729bcbbf5b24a64e51dd258c039bed4e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <[email protected]> Gerrit-Reviewer: Shahar Havivi <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
