Sandro Bonazzola has posted comments on this change. Change subject: don't use vdsm backend when there is not valid vol or imgUUID ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/36051/2/ovirt_hosted_engine_ha/agent/hosted_engine.py File ovirt_hosted_engine_ha/agent/hosted_engine.py: Line 424: } Line 425: # check if we have all the needed config params needed for vdsm api Line 426: if [v for k, v in storage_params.items() Line 427: if v in ('', None, 'None')]: Line 428: storage_params = { if [v for v in storage_params.values() if v in ('', None, 'None')]: or maybe better: if set(('', None, 'None')) & set(storage_params.values()): Line 429: 'sd_uuid': sd_uuid, Line 430: 'dom_type': dom_type Line 431: } Line 432: storage_backend_type = StorageBackendTypes.FilesystemBackend -- To view, visit http://gerrit.ovirt.org/36051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idcd181d260f4f20676a4124b899575b42935753c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Jiří Moskovčák <jmosk...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Artyom Lukianov <aluki...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
