Arik Hadas has posted comments on this change. Change subject: engine: Prevents duplicates parameters in multiple actions ......................................................................
Patch Set 1: Code-Review+1 (2 comments) http://gerrit.ovirt.org/#/c/36102/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromPoolRunner.java: Line 62: return getFirstParam() != null ? getFirstParam().getVmPoolId() : null; Line 63: } Line 64: Line 65: private RemoveVmFromPoolParameters getFirstParam() { Line 66: Iterator<VdcActionParametersBase> iterator = getParameters() == null ? null : getParameters().iterator(); since we don't really need the VdcActionParametersBase type I would change it to: Iterator<?> ... and then assign it to Object and check if this Object is instance of RemoveVmFromPoolParameters. but that's a matter of style Line 67: if (iterator != null && iterator.hasNext()) { Line 68: VdcActionParametersBase param = iterator.next(); Line 69: if (param instanceof RemoveVmFromPoolParameters) { Line 70: return ((RemoveVmFromPoolParameters) param); http://gerrit.ovirt.org/#/c/36102/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AttachStorageDomainsMultipleActionRunner.java: Line 26: } Line 27: Line 28: @Override Line 29: public ArrayList<VdcReturnValueBase> execute() { Line 30: Iterator<VdcActionParametersBase> iterator = getParameters() == null ? null : getParameters().iterator(); same here Line 31: if (iterator != null && iterator.hasNext()) { Line 32: VdcActionParametersBase parameter = iterator.next(); Line 33: StoragePool pool = DbFacade.getInstance().getStoragePoolDao().get( Line 34: ((StorageDomainPoolParametersBase) parameter).getStoragePoolId()); -- To view, visit http://gerrit.ovirt.org/36102 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic874d31535d2189f934d629e689aa7a534c165d5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Arik Hadas <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
